-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the workflow of archiving version from version details page #3278
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3278 +/- ##
==========================================
- Coverage 84.77% 84.74% -0.03%
==========================================
Files 1309 1309
Lines 29292 29292
Branches 7955 7955
==========================================
- Hits 24831 24824 -7
- Misses 4461 4468 +7
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Works as expected. After archiving a version, the URL takes me to versions list page instead of the archived version page.
/lgtm - Verified locally, works as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ppadti
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-13063
Description
This PR aims to update the workflow of archiving version from version details page. Now if we archive a version from version details page it will redirect to versions list page
How Has This Been Tested?
Archive a version from the version details page and see that navigates to versions list page after archiving a version.
Test Impact
NA, updated the navigation after archive.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main