Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImagePullBackOff is not handled as error during workbench start #3260

Merged
merged 1 commit into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/pages/projects/notebook/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@
if (!gracePeriod && lastItem.reason === 'FailedScheduling') {
currentEvent = 'Insufficient resources to start';
status = EventStatus.ERROR;
} else if (!gracePeriod && lastItem.reason === 'BackOff') {
currentEvent = 'ImagePullBackOff';
status = EventStatus.ERROR;

Check warning on line 244 in frontend/src/pages/projects/notebook/utils.ts

View check run for this annotation

Codecov / codecov/patch

frontend/src/pages/projects/notebook/utils.ts#L242-L244

Added lines #L242 - L244 were not covered by tests
} else if (lastItem.type === 'Warning') {
currentEvent = 'Issue creating notebook container';
status = EventStatus.WARNING;
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/utilities/notebookControllerUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,9 @@
if (!gracePeriod && lastItem.reason === 'FailedScheduling') {
currentEvent = 'Insufficient resources to start';
status = EventStatus.ERROR;
} else if (!gracePeriod && lastItem.reason === 'BackOff') {
currentEvent = 'ImagePullBackOff';
status = EventStatus.ERROR;

Check warning on line 440 in frontend/src/utilities/notebookControllerUtils.ts

View check run for this annotation

Codecov / codecov/patch

frontend/src/utilities/notebookControllerUtils.ts#L438-L440

Added lines #L438 - L440 were not covered by tests
} else if (lastItem.type === 'Warning') {
currentEvent = 'Issue creating notebook container';
status = EventStatus.WARNING;
Expand Down
Loading