Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack chart issue when there is no data for one area #3229

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 19, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-11048

Description

This is a known issue in Victory chart, and I am taking the workaround as suggested by the PF team here patternfly/patternfly-react#10978 (comment). If there is no data, we render it as [null] instead of [], which fixes the issue.

How Has This Been Tested?

I met some problems with generating the real data points, but you can go to the cypress test server and check the test case Serving Chart Shows Data

Way to compare:

  1. Run cypress:server and cypress:open:mock in 2 terminals
  2. Add it.only to the Serving Chart Shows Data test so we can check the screenshot
  3. Go to modelMetrics test to check if it renders incorrectly
  4. Run cypress:server:build and re-run step 1-3
  5. You can see the data renders correctly

Test Impact

Update the test cases to see the mocked data better.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (6a6a03a) to head (77ec5e0).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3229   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files        1279     1279           
  Lines       28161    28162    +1     
  Branches     7525     7526    +1     
=======================================
+ Hits        24071    24072    +1     
  Misses       4090     4090           
Files with missing lines Coverage Δ
...ages/modelServing/screens/metrics/MetricsChart.tsx 88.63% <100.00%> (+0.13%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6a03a...77ec5e0. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

this looks good to me

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 83730aa into opendatahub-io:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants