Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update breadcrumb title for edit connection type page #3220

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-12827

Description

Fixes the breadcrumb of the edit connection type page which use to say Create connection type.

Updated screenshot:
image

cc @simrandhaliw

How Has This Been Tested?

Manually by editing a connection type.

Test Impact

N/A copy change

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (b5351a7) to head (edcdf54).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3220      +/-   ##
==========================================
+ Coverage   85.39%   85.46%   +0.07%     
==========================================
  Files        1277     1279       +2     
  Lines       28082    28161      +79     
  Branches     7487     7525      +38     
==========================================
+ Hits        23980    24068      +88     
+ Misses       4102     4093       -9     
Files with missing lines Coverage Δ
...onTypes/manage/ManageConnectionTypeBreadcrumbs.tsx 100.00% <100.00%> (ø)
...onnectionTypes/manage/ManageConnectionTypePage.tsx 92.30% <100.00%> (ø)

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5351a7...edcdf54. Read the comment docs.

@jeff-phillips-18
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fa9e57f into opendatahub-io:main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants