-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display storage class selected in workbenches #3214
Conversation
/hold |
@xianli123 Can you please have a look at the screenshot attached above |
9b39af5
to
1183dfb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3214 +/- ##
==========================================
+ Coverage 85.39% 85.49% +0.10%
==========================================
Files 1277 1280 +3
Lines 28082 28229 +147
Branches 7487 7558 +71
==========================================
+ Hits 23980 24134 +154
+ Misses 4102 4095 -7
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/pages/projects/screens/detail/storage/StorageTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/screens/detail/storage/StorageTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/screens/detail/storage/StorageTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/screens/detail/storage/StorageTable.tsx
Outdated
Show resolved
Hide resolved
Thanks @pnaik1! That works for me. |
/unhold |
frontend/src/pages/projects/screens/detail/storage/StorageTableRow.tsx
Outdated
Show resolved
Hide resolved
d8b7818
to
2b302b5
Compare
frontend/src/pages/projects/screens/detail/storage/StorageTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one comment
2b302b5
to
43b6019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
this looks good, thanks for the changes
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-1110
Description
Cluster storage page
when storage class is deprecated/disabled
when storage class is deleted
How Has This Been Tested?
When feature flag is off
When feature flag is on
Test Impact
Added cypress test to it
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main