-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-12310] Error cases for storage class admin table #3213
[RHOAIENG-12310] Error cases for storage class admin table #3213
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3213 +/- ##
==========================================
+ Coverage 85.39% 85.48% +0.08%
==========================================
Files 1277 1279 +2
Lines 28082 28159 +77
Branches 7487 7523 +36
==========================================
+ Hits 23980 24071 +91
+ Misses 4102 4088 -14
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one comment
frontend/src/pages/storageClasses/ResetCorruptConfigValueAlert.tsx
Outdated
Show resolved
Hide resolved
da97a1a
to
24f4d53
Compare
24f4d53
to
d9bd9a3
Compare
Thanks! LGTM. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-12310
Description
Show error/warning alerts for scenarios where individual storage class config values or the entire config are malformed in some way. Introduce abilities to correct those mistakes possibly made via the Openshift UI within the ODH dashboard's storage class table.
Unreadable config demo:
https://github.com/user-attachments/assets/86b3cda6-f5c4-41cf-bcdc-92f8787f9b61
Invalid data, default, enable config values:
https://github.com/user-attachments/assets/35a9d29c-f889-4101-a2f2-690fe4a8afbb
Invalid Display name demo:
https://github.com/user-attachments/assets/af5d969f-450c-4303-a1e5-3057554d114d
Invalid Description demo:
https://github.com/user-attachments/assets/8f4b14a3-b97f-4035-b24c-0f8d28a885b7
Invalid Display name and description demo:
https://github.com/user-attachments/assets/9fd6f80f-5590-42e9-b524-3c7db61c7b16
(cc @xianli123)
How Has This Been Tested?
/search/ns/opendatahub?q=&kind=storage.k8s.io~v1~StorageClass
by clicking on individual row actions,Edit annotations
, then update theopendatahub.io/sc-config
value to force invalid data.With the feature flag enabled, visit the storage class table's page;
/storageClasses?devFeatureFlags=disableStorageClasses
Test Impact
Added cypress test covering multiple error cases
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main