CVE-2024-41818 odh-dashboard-container: ReDOS at currency parsing in currency.js [main] #3193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/RHOAIENG-12691
Description
This CVE is from
fast-xml-parser
package, which is a sub-dependency ofminio
package. We don't use the package anymore because we removed it in #3086 and use DSP Artifacts API to fetch the storage object instead of connecting to the minio.So remove the dependency here to fix the CVE.
How Has This Been Tested?
Make sure there is no
fast-xml-parser
in package-lock.json and the dashboard is running with no problem.Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main