Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2024-41818 odh-dashboard-container: ReDOS at currency parsing in currency.js [main] #3193

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 11, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-12691

Description

This CVE is from fast-xml-parser package, which is a sub-dependency of minio package. We don't use the package anymore because we removed it in #3086 and use DSP Artifacts API to fetch the storage object instead of connecting to the minio.
So remove the dependency here to fix the CVE.

How Has This Been Tested?

Make sure there is no fast-xml-parser in package-lock.json and the dashboard is running with no problem.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (4fabe0c) to head (dd9b38a).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3193   +/-   ##
=======================================
  Coverage   85.27%   85.28%           
=======================================
  Files        1258     1258           
  Lines       27690    27691    +1     
  Branches     7372     7373    +1     
=======================================
+ Hits        23614    23615    +1     
  Misses       4076     4076           

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fabe0c...dd9b38a. Read the comment docs.

@Gkrumbach07
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4b77632 into opendatahub-io:main Sep 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants