Project selector is scrollable in Deploy model modal #3169
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3169 +/- ##
==========================================
- Coverage 85.27% 85.27% -0.01%
==========================================
Files 1258 1258
Lines 27689 27689
Branches 7372 7372
==========================================
- Hits 23612 23611 -1
- Misses 4077 4078 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
tested locally, |
| @@ -341,4 +341,63 @@ describe('Deploy model version', () => { | |||
| kserveModal.selectExistingConnectionSelectOptionByResourceName('test-secret-not-match'); | |||
| kserveModal.findExistingConnectionSelect().should('not.contain.text', 'Recommended'); | |||
| }); | |||
|
|
|||
| it('Test project dropdown scroll in Deploy model modal', () => { | |||
There was a problem hiding this comment.
this test passes even without the isScrollable added. i think to actually test you'd have to scroll with cypress and check if visible, but don't think it is necessary anyway as you end up just testing a patternfly component
manaswinidas
force-pushed
the
scroll-project-selector
branch
from
78ecdea
to
0d899ab
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-11864
Description
Project selector is scrollable in Deploy Model modal in Model Registry
How Has This Been Tested?
Deployby clicking on that kebab menu in that specific rowSelect target projectinDeploy model.Test Impact
Manually and Cypress tests added
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main