Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alignment of text for connection type form elements #3162

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Sep 6, 2024

https://issues.redhat.com/browse/RHOAIENG-12573

Description

Removed the enable checkbox from the type details section which allows it more room to display without text wrapping.
image

Removed the col span from the section title cell in order to constrain the text to its column.
image

Added missing icon to search inputs:
image

cc @simrandhaliw

How Has This Been Tested?

Manually.
Visual only changes.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (85f2b31) to head (e043623).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...concepts/connectionTypes/ConnectionTypePreview.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3162      +/-   ##
==========================================
- Coverage   85.26%   85.24%   -0.02%     
==========================================
  Files        1258     1258              
  Lines       27684    27684              
  Branches     7372     7372              
==========================================
- Hits        23604    23600       -4     
- Misses       4080     4084       +4     
Files with missing lines Coverage Δ
frontend/src/components/TruncatedText.tsx 100.00% <ø> (ø)
...es/connectionTypes/ConnectionTypesTableToolbar.tsx 84.21% <100.00%> (ø)
...src/pages/connectionTypes/EmptyConnectionTypes.tsx 100.00% <ø> (ø)
...ypes/manage/ManageConnectionTypeFieldsTableRow.tsx 86.20% <ø> (ø)
...onnectionTypes/manage/ManageConnectionTypePage.tsx 92.30% <100.00%> (ø)
...concepts/connectionTypes/ConnectionTypePreview.tsx 5.26% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f2b31...e043623. Read the comment docs.

@emilys314
Copy link
Contributor

The checkbox does indeed go wider. Also the col span for name / desc is only on it's own column.

However, in your screenshot i see a 2 line truncated description, i don't seem to see that?
image

@christianvogt
Copy link
Contributor Author

@emilys314 I've updated TruncatedText to include overflowWrap: 'anywhere'. This is the style you applied to the preview to address the same issue there.

@emilys314
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d89ab8d into opendatahub-io:main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants