-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix alignment of text for connection type form elements #3162
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3162 +/- ##
==========================================
- Coverage 85.26% 85.24% -0.02%
==========================================
Files 1258 1258
Lines 27684 27684
Branches 7372 7372
==========================================
- Hits 23604 23600 -4
- Misses 4080 4084 +4
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@emilys314 I've updated |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-12573
Description
Removed the enable checkbox from the type details section which allows it more room to display without text wrapping.
Removed the col span from the section title cell in order to constrain the text to its column.
Added missing icon to search inputs:
cc @simrandhaliw
How Has This Been Tested?
Manually.
Visual only changes.
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main