Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long connection type description #3159

Conversation

emilys314
Copy link
Contributor

@emilys314 emilys314 commented Sep 5, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-12443

Description

This is a visual styling change to fix long descriptions. You can still enter really long descripitons, but it won't overflow outside the container the text is in.

I also saw this is a similar issue in the preview page, no idea why. But I fixed that as well.

Before:
Screenshot from 2024-09-05 11-43-08
After:
Screenshot from 2024-09-05 11-39-25

Preview before:
Screenshot from 2024-09-05 11-43-20
After:
Screenshot from 2024-09-05 11-39-49

How Has This Been Tested?

Tested locally

Test Impact

A shared component has been updated, but the new prop is default unsued

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Sep 5, 2024
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (7856a84) to head (7017943).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../src/components/table/TableRowTitleDescription.tsx 66.66% 1 Missing ⚠️
...concepts/connectionTypes/ConnectionTypePreview.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   85.18%   85.16%   -0.02%     
==========================================
  Files        1252     1253       +1     
  Lines       27511    27544      +33     
  Branches     7320     7336      +16     
==========================================
+ Hits        23434    23459      +25     
- Misses       4077     4085       +8     
Files with missing lines Coverage Δ
...src/pages/connectionTypes/ConnectionTypesTable.tsx 80.00% <ø> (ø)
.../pages/connectionTypes/ConnectionTypesTableRow.tsx 62.22% <ø> (ø)
frontend/src/pages/connectionTypes/columns.ts 44.44% <ø> (ø)
.../src/components/table/TableRowTitleDescription.tsx 94.11% <66.66%> (-5.89%) ⬇️
...concepts/connectionTypes/ConnectionTypePreview.tsx 5.26% <0.00%> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7856a84...7017943. Read the comment docs.

@emilys314 emilys314 marked this pull request as ready for review September 5, 2024 17:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 5, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5a4ca21 into opendatahub-io:main Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants