-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show connection type creation error message on failure #3158
Show connection type creation error message on failure #3158
Conversation
ac29303
to
01c533d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3158 +/- ##
==========================================
+ Coverage 85.18% 85.25% +0.07%
==========================================
Files 1252 1253 +1
Lines 27511 27544 +33
Branches 7320 7336 +16
==========================================
+ Hits 23434 23482 +48
+ Misses 4077 4062 -15
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Good point. I tried this and you can edit the name of the resource to be the same name as another connection type. I think we probably want to prevent this. Leading back to the other discussion of checking for duplicate names before attempting to save. @christianvogt Thoughts? |
@jeff-phillips-18 let's start a conversation about showing the k8s resource name in the UI. No need to handle duplicates as part of this work. |
01c533d
to
323fc9f
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes RHOAIENG-12439
Description
Fix handling of the error response when creating a connection type.
How Has This Been Tested?
Tested manually
Test Impact
Added e2e test to verify response error text is shown on the page after an error.
Request review criteria:
Self checklist (all need to be checked):