Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upversion Node & NPM to match other dependency needs #3154

Merged

Conversation

andrewballantyne
Copy link
Member

Due to issues with various optional dependencies (who don't report errors until you made the dev dependencies), we need to be on v18.18 of Node. Our previous recommended versions did not match this, updating them.

I matched the NPM version that was auto upgraded when I switched my Node.

@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti September 4, 2024 12:58
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (57ce8a7) to head (6eebea1).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
- Coverage   85.16%   85.14%   -0.02%     
==========================================
  Files        1251     1251              
  Lines       27384    27423      +39     
  Branches     7261     7274      +13     
==========================================
+ Hits        23322    23350      +28     
- Misses       4062     4073      +11     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ce8a7...6eebea1. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0866126 into opendatahub-io:main Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants