-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error text for duplicate label and value #3151
Add error text for duplicate label and value #3151
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
==========================================
- Coverage 85.16% 85.16% -0.01%
==========================================
Files 1251 1251
Lines 27384 27453 +69
Branches 7261 7292 +31
==========================================
+ Hits 23322 23379 +57
- Misses 4062 4074 +12
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/lgtm works well to present the errors and prevent form submission |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes https://issues.redhat.com/browse/RHOAIENG-10322
Description
Adds error text if there are duplicate entries for the labels and columns row.
The first entry will not have the error text, only the subsequent entries, which is similar to the file upload.
How Has This Been Tested?
Has been tested locally and jest unit tests have been added
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main