-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix env variable input field issues on Notebook controller spawner #3146
Fix env variable input field issues on Notebook controller spawner #3146
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3146 +/- ##
==========================================
- Coverage 85.16% 85.16% -0.01%
==========================================
Files 1251 1251
Lines 27384 27388 +4
Branches 7261 7264 +3
==========================================
+ Hits 23322 23324 +2
- Misses 4062 4064 +2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I see unless we type the |
d6883a6
to
67f7048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
code looks good
/lgtm, tested locally |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-9502
Description
Solved 2 issues:
How Has This Been Tested?
Launch application
on the Jupyter cardCustom variable
option again (though it's selected already)Test Impact
N/A, we don't have tests for the notebook controller, not sure if it is worth the effort for this page.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main