Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env variable input field issues on Notebook controller spawner #3146

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Aug 30, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-9502

Description

Solved 2 issues:

  1. Don't show the error message when the name is initially generated or empty
  2. Check the name field and disabled the submit button if the name field is initially generated or empty

How Has This Been Tested?

  1. Go to Enabled page
  2. Go to the notebook controller spawner page by clicking on Launch application on the Jupyter card
  3. At the bottom of the page, click "Add more variables"
  4. In the first item dropdown, click on the Custom variable option again (though it's selected already)
  5. Make sure there is no error helper text under the name field
  6. Make sure the "Start server" button is disabled
  7. Try to type in the name field, make sure the "Start server" button is enabled when the name field is not empty and disabled when the name field is empty
  8. Try to add more variables fields, and make sure the "Start server" button is disabled if any of the name fields is empty

Test Impact

N/A, we don't have tests for the notebook controller, not sure if it is worth the effort for this page.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (57ce8a7) to head (67f7048).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../notebookController/screens/server/SpawnerPage.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   85.16%   85.16%   -0.01%     
==========================================
  Files        1251     1251              
  Lines       27384    27388       +4     
  Branches     7261     7264       +3     
==========================================
+ Hits        23322    23324       +2     
- Misses       4062     4064       +2     
Files with missing lines Coverage Δ
...oller/screens/server/EnvironmentVariablesField.tsx 3.03% <ø> (ø)
.../notebookController/screens/server/SpawnerPage.tsx 64.55% <66.66%> (+0.27%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ce8a7...67f7048. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Sep 3, 2024

I see unless we type the variable name the submit button is disabled, can we make variable name required??

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

code looks good

@pnaik1
Copy link
Contributor

pnaik1 commented Sep 4, 2024

/lgtm, tested locally

@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b05e8ac into opendatahub-io:main Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants