-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MR tables default sort state #3145
Conversation
@yih-wang could you check the above screenshots? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
==========================================
- Coverage 85.20% 85.18% -0.02%
==========================================
Files 1244 1251 +7
Lines 27117 27420 +303
Branches 7152 7274 +122
==========================================
+ Hits 23104 23357 +253
- Misses 4013 4063 +50
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
LGTM, thanks @ppadti! |
ddc022f
to
1033d2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there's a typo
frontend/src/__tests__/cypress/cypress/pages/modelRegistry/registeredModelArchive.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisteredModels/RegisteredModelsTableColumns.ts
Show resolved
Hide resolved
1033d2d
to
dcadbc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ppadti
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-11505
Description
This PR aims to update the default sort state of registered models list, model versions list, archived models list.
How Has This Been Tested?
Last modified
for registered models list, archived models list.Test Impact
Added unit test.
Added and updated Cypress tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main