Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MR tables default sort state #3145

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Aug 30, 2024

Closes: RHOAIENG-11505

Description

This PR aims to update the default sort state of registered models list, model versions list, archived models list.

Screenshot from 2024-08-30 17-22-58

Screenshot from 2024-08-30 21-35-13

Screenshot from 2024-08-30 21-34-48

How Has This Been Tested?

  • Verify that the default sort state set to Last modified for registered models list, archived models list.
  • No default sort state for model versions list and versions are sorted by create time.

Test Impact

Added unit test.
Added and updated Cypress tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti
Copy link
Contributor Author

ppadti commented Aug 30, 2024

@yih-wang could you check the above screenshots?

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (3174a74) to head (dcadbc8).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3145      +/-   ##
==========================================
- Coverage   85.20%   85.18%   -0.02%     
==========================================
  Files        1244     1251       +7     
  Lines       27117    27420     +303     
  Branches     7152     7274     +122     
==========================================
+ Hits        23104    23357     +253     
- Misses       4013     4063      +50     
Files with missing lines Coverage Δ
frontend/src/concepts/modelRegistry/types.ts 100.00% <ø> (ø)
...try/screens/ModelVersions/ModelVersionListView.tsx 86.04% <ø> (ø)
...istry/screens/ModelVersions/ModelVersionsTable.tsx 100.00% <ø> (ø)
.../screens/RegisteredModels/RegisteredModelTable.tsx 100.00% <ø> (ø)
...s/RegisteredModels/RegisteredModelsTableColumns.ts 100.00% <100.00%> (+66.66%) ⬆️
...eredModelsArchive/RegisteredModelsArchiveTable.tsx 100.00% <ø> (ø)
...odelRegistry/screens/components/ModelTimestamp.tsx 71.42% <ø> (ø)
frontend/src/pages/modelRegistry/screens/utils.ts 88.88% <100.00%> (+0.82%) ⬆️

... and 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3174a74...dcadbc8. Read the comment docs.

@yih-wang
Copy link

yih-wang commented Sep 2, 2024

LGTM, thanks @ppadti!

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a typo

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ppadti

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fcdd7ae into opendatahub-io:main Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants