-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection type dropdown advanced properties #3143
Add connection type dropdown advanced properties #3143
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
==========================================
+ Coverage 85.13% 85.16% +0.02%
==========================================
Files 1250 1251 +1
Lines 27272 27332 +60
Branches 7209 7233 +24
==========================================
+ Hits 23219 23276 +57
- Misses 4053 4056 +3
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
0cd0bc7
to
9f2fd27
Compare
frontend/src/concepts/connectionTypes/fields/DropdownFormField.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/DropdownAdvancedPropertiesForm.tsx
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/DropdownAdvancedPropertiesForm.tsx
Outdated
Show resolved
Hide resolved
|
||
React.useEffect(() => { | ||
// TODO: warn user of duplicate values in table | ||
const duplicates = properties.items?.find((item1, index1) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care if labels are the same? Imo labels should differ. But since we render the value at all times as well it doesn't really matter to have unique labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, maybe we followup alongside the warning of duplicate values
frontend/src/pages/connectionTypes/manage/advanced/DropdownAdvancedPropertiesForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/DropdownAdvancedPropertiesForm.tsx
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Completes https://issues.redhat.com/browse/RHOAIENG-10322
Description
Initial state
Single select with options:
Multi select with options (and 1 blank option that is omitted):
Single select with options (1 is missing a label, a 2nd is missing a value)
How Has This Been Tested?
Test Impact
Jest tests have been added like the other advanced forms to test all the functionality of the component
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
@simrandhaliw
After the PR is posted & before it merges:
main