Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MR detail): truncate description in header #3138

Conversation

gitdallas
Copy link
Contributor

closes: https://issues.redhat.com/browse/RHOAIENG-12026

Description

truncates long descriptions in the header for mr details
image

How Has This Been Tested?

ran locally

Test Impact

no logical change, no test impact

Request review criteria:

description is truncated if it would extend multiple lines, on hover a tooltip will show up

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@gitdallas gitdallas force-pushed the feat/12026-truncate-desc-in-header branch 2 times, most recently from b20d55b to 015b803 Compare August 29, 2024 15:43
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.21%. Comparing base (3174a74) to head (241863f).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
+ Coverage   85.20%   85.21%   +0.01%     
==========================================
  Files        1244     1244              
  Lines       27117    27117              
  Branches     7152     7152              
==========================================
+ Hits        23104    23109       +5     
+ Misses       4013     4008       -5     
Files with missing lines Coverage Δ
...creens/ModelVersionDetails/ModelVersionDetails.tsx 90.32% <100.00%> (ø)
...elRegistry/screens/ModelVersions/ModelVersions.tsx 100.00% <100.00%> (ø)
...odelVersionsArchive/ModelVersionArchiveDetails.tsx 100.00% <100.00%> (ø)
...redModelsArchive/RegisteredModelArchiveDetails.tsx 96.15% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3174a74...241863f. Read the comment docs.

@ppadti
Copy link
Contributor

ppadti commented Aug 29, 2024

@gitdallas I think we have to truncate the description in few more pages as mentioned in the ticket - version details page, archived model details page and archived version details page.

@gitdallas gitdallas force-pushed the feat/12026-truncate-desc-in-header branch from 015b803 to 241863f Compare August 29, 2024 18:06
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. But the layout changes a little in Model version Details page. The dropdown and Actions button look like this(earlier they were positioned horizontally from side-to-side, now they are vertical) while truncating big descriptions. @yih-wang is this expected?
Screenshot 2024-09-02 at 4 40 17 PM

@yih-wang
Copy link

yih-wang commented Sep 3, 2024

Update: Just talked to @yannnz and she kinda likes to keep this layout for pipeline screen. So for consistency consideration, let's hold off on this change. Need further discussion of whether we want to modify the layout here for model registry solely.

@manaswinidas Good catch!
I raised this issue to the post-mvp scope during my overall review. Not sure how large the issue is to be addressed in this pr. I'm okay with addressing this either in this PR or leaving it for the post-MVP.
Also, this issue might come from the pipeline code we're reusing since the pipeline version details page also has the same layout issue. It will be great if we can address this issue in both places together.

@manaswinidas
Copy link
Contributor

Thanks @yih-wang for the clarification!

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gitdallas

Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 715f2e2 into opendatahub-io:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants