-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MR detail): truncate description in header #3138
feat(MR detail): truncate description in header #3138
Conversation
b20d55b
to
015b803
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3138 +/- ##
==========================================
+ Coverage 85.20% 85.21% +0.01%
==========================================
Files 1244 1244
Lines 27117 27117
Branches 7152 7152
==========================================
+ Hits 23104 23109 +5
+ Misses 4013 4008 -5
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@gitdallas I think we have to truncate the description in few more pages as mentioned in the ticket - version details page, archived model details page and archived version details page. |
Signed-off-by: gitdallas <[email protected]>
015b803
to
241863f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. But the layout changes a little in Model version Details page. The dropdown and Actions button look like this(earlier they were positioned horizontally from side-to-side, now they are vertical) while truncating big descriptions. @yih-wang is this expected?
Update: Just talked to @yannnz and she kinda likes to keep this layout for pipeline screen. So for consistency consideration, let's hold off on this change. Need further discussion of whether we want to modify the layout here for model registry solely. @manaswinidas Good catch! |
Thanks @yih-wang for the clarification! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gitdallas
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-12026
Description
truncates long descriptions in the header for mr details
How Has This Been Tested?
ran locally
Test Impact
no logical change, no test impact
Request review criteria:
description is truncated if it would extend multiple lines, on hover a tooltip will show up
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main