Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tab layout issue on Artifact node side panel #3135

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Aug 28, 2024

JIRA: RHOAIENG-11567

Description

Add a style to prevent tabs from shrinking.

Screenshot 2024-08-28 at 2 07 18 PM

How Has This Been Tested?

  1. Create a run using the metrics pipeline
  2. Click on the artifact nodes
  3. Make sure the tabs are not hidden anymore when you click on the Visualization tab

Test Impact

N/A, a small UX fix.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (4a0626e) to head (5e644f5).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3135      +/-   ##
==========================================
+ Coverage   80.84%   80.87%   +0.03%     
==========================================
  Files        1243     1244       +1     
  Lines       27099    27117      +18     
  Branches     7144     7152       +8     
==========================================
+ Hits        21907    21930      +23     
+ Misses       5192     5187       -5     
Files with missing lines Coverage Δ
...ipelineRun/artifacts/ArtifactNodeDrawerContent.tsx 88.23% <ø> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0626e...5e644f5. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Aug 29, 2024

Tested locally
The arttifact tab doesnt shrink/tabs are not hidden, when clicking on visualization tab

/lgtm

Screenshot 2024-08-29 at 7 29 23 PM

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

tested locally and the tab does not get hidden

Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DaoDaoNoCode
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 0a150b6 into opendatahub-io:main Aug 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants