Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-11215 - FIx for Model Registry Stuck Progress #3131

Merged

Conversation

YuliaKrimerman
Copy link
Contributor

RHOAIENG-11215

Description

Removed the use of lastAvailableConditionTime and Moved the Unavailable to be the first in the queue

How Has This Been Tested?

To test - create good, and bad connection to the db, and test that none of them get's stuck in Progressing status(refresh the page when needed, as it looks like the refresh bug is still not fixed)
Screenshot 2024-08-27 at 9 53 09 AM

Test Impact

I've removed all the test that were testing lastAvailableConditionTime

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (dc4599e) to head (7bfa560).
Report is 14 commits behind head on main.

Files Patch % Lines
...elRegistrySettings/ModelRegistryTableRowStatus.tsx 92.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
- Coverage   80.89%   80.81%   -0.08%     
==========================================
  Files        1239     1240       +1     
  Lines       26888    26948      +60     
  Branches     7038     7075      +37     
==========================================
+ Hits        21752    21779      +27     
- Misses       5136     5169      +33     
Files Coverage Δ
...elRegistrySettings/ModelRegistryTableRowStatus.tsx 91.35% <92.00%> (-5.16%) ⬇️

... and 40 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4599e...7bfa560. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on the modelregistry-ui cluster by creating a registry with bad database credentials, waiting for it to be Unavailable, then deleting the deployment. On the cluster's production dashboard UI it gets stuck in Progressing and with this change running locally it stays in Unavailable.

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e6b8708 into opendatahub-io:main Aug 27, 2024
8 checks passed
@YuliaKrimerman YuliaKrimerman deleted the RHOAIENG-11215 branch October 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants