-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-11215 - FIx for Model Registry Stuck Progress #3131
RHOAIENG-11215 - FIx for Model Registry Stuck Progress #3131
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
==========================================
- Coverage 80.89% 80.81% -0.08%
==========================================
Files 1239 1240 +1
Lines 26888 26948 +60
Branches 7038 7075 +37
==========================================
+ Hits 21752 21779 +27
- Misses 5136 5169 +33
... and 40 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested on the modelregistry-ui cluster by creating a registry with bad database credentials, waiting for it to be Unavailable, then deleting the deployment. On the cluster's production dashboard UI it gets stuck in Progressing and with this change running locally it stays in Unavailable.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RHOAIENG-11215
Description
Removed the use of lastAvailableConditionTime and Moved the Unavailable to be the first in the queue
How Has This Been Tested?
To test - create good, and bad connection to the db, and test that none of them get's stuck in Progressing status(refresh the page when needed, as it looks like the refresh bug is still not fixed)
Test Impact
I've removed all the test that were testing lastAvailableConditionTime
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main