Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backend route for storage class metadata #3127

Conversation

Gkrumbach07
Copy link
Member

closes: https://issues.redhat.com/browse/RHOAIENG-11855

Description

adds backend route /api/storage-class/{name}/metadata and a frontend service function to call it

How Has This Been Tested?

backend -- no tests

Test Impact

none

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function looks good to me. Just need to fix the lint to avoid duplicated import paths.
One quick question: Should we change the endpoint name and the function name here? Looks like the function is trying to update the SC annotation only, but not the whole metadata, should we still call them /:storageClassName/metadata and updateStorageClassMetadata?

@Gkrumbach07
Copy link
Member Author

/retest Test

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

@Gkrumbach07: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test odh-dashboard-pr-image-mirror

Use /test all to run all jobs.

In response to this:

/retest Test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gkrumbach07
Copy link
Member Author

/retest failed

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

@Gkrumbach07: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test odh-dashboard-pr-image-mirror

Use /test all to run all jobs.

In response to this:

/retest failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

frontend/src/services/StorageClassService.ts Outdated Show resolved Hide resolved
backend/src/types.ts Show resolved Hide resolved
backend/src/routes/api/storage-class/index.ts Show resolved Hide resolved
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (5e854fe) to head (cafdf34).
Report is 8 commits behind head on main.

Files Patch % Lines
frontend/src/services/StorageClassService.ts 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3127      +/-   ##
==========================================
- Coverage   80.88%   80.81%   -0.08%     
==========================================
  Files        1239     1241       +2     
  Lines       26895    26960      +65     
  Branches     7041     7079      +38     
==========================================
+ Hits        21755    21788      +33     
- Misses       5140     5172      +32     
Files Coverage Δ
frontend/src/services/StorageClassService.ts 0.00% <0.00%> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e854fe...cafdf34. Read the comment docs.

@Gkrumbach07
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07, jpuzz0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 36e69b9 into opendatahub-io:main Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants