-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add backend route for storage class metadata #3127
add backend route for storage class metadata #3127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function looks good to me. Just need to fix the lint to avoid duplicated import paths.
One quick question: Should we change the endpoint name and the function name here? Looks like the function is trying to update the SC annotation only, but not the whole metadata, should we still call them /:storageClassName/metadata
and updateStorageClassMetadata
?
/retest Test |
@Gkrumbach07: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest failed |
@Gkrumbach07: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3127 +/- ##
==========================================
- Coverage 80.88% 80.81% -0.08%
==========================================
Files 1239 1241 +2
Lines 26895 26960 +65
Branches 7041 7079 +38
==========================================
+ Hits 21755 21788 +33
- Misses 5140 5172 +32
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07, jpuzz0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-11855
Description
adds backend route
/api/storage-class/{name}/metadata
and a frontend service function to call itHow Has This Been Tested?
backend -- no tests
Test Impact
none
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main