-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
surface conflicting env var names as warnings and errors #3124
surface conflicting env var names as warnings and errors #3124
Conversation
frontend/src/pages/connectionTypes/manage/ConnectionTypeDataFieldModal.tsx
Show resolved
Hide resolved
I tested this on my cluster and it looks like it's all working to me |
a668a36
to
1bd8f58
Compare
@emilys314 updated with |
/lgtm |
1bd8f58
to
735499b
Compare
735499b
to
ba57158
Compare
rebased to fix all the conflicts with |
ba57158
to
e13871f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
==========================================
+ Coverage 80.84% 80.85% +0.01%
==========================================
Files 1243 1244 +1
Lines 27099 27117 +18
Branches 7144 7152 +8
==========================================
+ Hits 21907 21926 +19
+ Misses 5192 5191 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
e13871f
to
92efced
Compare
rebased |
92efced
to
46d54e2
Compare
46d54e2
to
bf5e8dd
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-11538
Description
Provides user with feedback when creating fields which have conflicting env var values.
Note that microcopy is not finalized.
cc @simrandhaliw
How Has This Been Tested?
Settings
->Connection types
as an admin with the connection type feature flag enabled.Test Impact
Added unit tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main