-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent duplicity post of creating/replacing elyra secret #3120
Prevent duplicity post of creating/replacing elyra secret #3120
Conversation
Tested locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
this looks good.
bb1ba4a
to
0432780
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3120 +/- ##
==========================================
- Coverage 85.17% 85.13% -0.04%
==========================================
Files 1251 1251
Lines 27436 27443 +7
Branches 7280 7283 +3
==========================================
- Hits 23369 23364 -5
- Misses 4067 4079 +12
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
JIRA: https://issues.redhat.com/browse/RHOAIENG-10719
Description
Add a ref to prevent simultaneously creating/replacing the elyra secret, and rewrite the hook a little bit to make it more readable.
How Has This Been Tested?
ds-pipeline-config
secretTest Impact
N/A, needs e2e live test for that which #3028 will cover.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main