Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update preview panel to align with latest ux #3115

Merged

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Aug 21, 2024

https://issues.redhat.com/browse/RHOAIENG-11539

Description

Updated the preview header to use a white background and made it sticky to the top so that the scrollable area is the drawer body.

No connection type name or description:
image

image

Has connection type name, description and category:
image
image
image

Popovers for field descriptions:
image

Updated dropdown review to include values:
image

Preview hidden default read only values. Use popover to see real value.
image
image

cc @simrandhaliw

Additional changes:

  • update the config map types to include category
  • updated serialization utils to handle category
  • added reusable CategoryLabel component
  • adjusted field table column widths
  • used React.memo for performance improvements

How Has This Been Tested?

Existing tests. Manually. For the most part this is just look and feel changes.

  • Enable the connection types feature flag
  • Go to Settings -> Connection types
  • Create a connection type
  • Open the preview panel
  • Create various fields with different values

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@christianvogt christianvogt added the do-not-merge/hold This PR is hold for some reason label Aug 21, 2024
@christianvogt christianvogt removed the do-not-merge/hold This PR is hold for some reason label Aug 21, 2024
@christianvogt christianvogt force-pushed the update-preview branch 2 times, most recently from bb871e8 to 041a7c0 Compare August 22, 2024 12:48
@christianvogt
Copy link
Contributor Author

Rebased and fixed up unit tests 🤞

@christianvogt christianvogt force-pushed the update-preview branch 4 times, most recently from 442aba1 to 01d3854 Compare August 22, 2024 13:07
@christianvogt
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor Author

Going to need #3119 fixed it seems to get around this test failure.

@christianvogt
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor Author

rebased

@jeff-phillips-18
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b8b44ea into opendatahub-io:main Aug 26, 2024
6 checks passed
emilys314 pushed a commit to emilys314/odh-dashboard that referenced this pull request Aug 27, 2024
emilys314 pushed a commit to emilys314/odh-dashboard that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants