-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update preview panel to align with latest ux #3115
update preview panel to align with latest ux #3115
Conversation
3a75300
to
927eac0
Compare
927eac0
to
6a91b4c
Compare
frontend/src/concepts/connectionTypes/ConnectionTypePreview.tsx
Outdated
Show resolved
Hide resolved
bb871e8
to
041a7c0
Compare
Rebased and fixed up unit tests 🤞 |
442aba1
to
01d3854
Compare
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Going to need #3119 fixed it seems to get around this test failure. |
/retest |
01d3854
to
1e9a4bc
Compare
rebased |
/lgtm |
https://issues.redhat.com/browse/RHOAIENG-11539
Description
Updated the preview header to use a white background and made it sticky to the top so that the scrollable area is the drawer body.
No connection type name or description:
Has connection type name, description and category:
Popovers for field descriptions:
Updated dropdown review to include values:
Preview hidden default read only values. Use popover to see real value.
cc @simrandhaliw
Additional changes:
CategoryLabel
componentReact.memo
for performance improvementsHow Has This Been Tested?
Existing tests. Manually. For the most part this is just look and feel changes.
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main