-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline scheduled toggle is disabled for schedules with an archived … #3109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the optimum solution and will create a lot of duplicated network calls.
- In https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableRowExperiment.tsx, we will make a call to fetch the experiment for each row already, we should look into extract that logic and make it reused by both the experiment column and the status toggle so that we can reduce the API calls, otherwise every row will make 2 same API calls to fetch the experiment.
- The changes you made to
useContextExperimentArchived
hook will also produce some duplicated API calls on the experiment schedules pages, which is unnecessary. On the experiment schedules table, everything is under the experiment context, and we should make sure we don't make extra API calls for the experiment again and fetch all the information we need from the experiment context because all the schedules on that page are from the same experiment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…experiment
https://issues.redhat.com/browse/RHOAIENG-10393
Description
In pipeline version schedules table, disable toggling when experiment is archived
How Has This Been Tested?
Test Impact
added cypress test cases
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main