Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline scheduled toggle is disabled for schedules with an archived … #3109

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Aug 21, 2024

…experiment

https://issues.redhat.com/browse/RHOAIENG-10393

Description

In pipeline version schedules table, disable toggling when experiment is archived

How Has This Been Tested?

  1. Create a schedule with an active experiment
  2. Archive that experiment
  3. Go to the pipeline version schedules table, and check that schedule, you can see the toggle button is disabled

Test Impact

added cypress test cases

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the optimum solution and will create a lot of duplicated network calls.

  1. In https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableRowExperiment.tsx, we will make a call to fetch the experiment for each row already, we should look into extract that logic and make it reused by both the experiment column and the status toggle so that we can reduce the API calls, otherwise every row will make 2 same API calls to fetch the experiment.
  2. The changes you made to useContextExperimentArchived hook will also produce some duplicated API calls on the experiment schedules pages, which is unnecessary. On the experiment schedules table, everything is under the experiment context, and we should make sure we don't make extra API calls for the experiment again and fetch all the information we need from the experiment context because all the schedules on that page are from the same experiment.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great
/lgtm
Screenshot 2024-08-26 at 12 53 48 PM

@openshift-ci openshift-ci bot added the lgtm label Aug 26, 2024
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3e40d40 into opendatahub-io:main Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants