-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dockerfile to use numeric user id #3088
Conversation
/lgtm |
Wow, I can lgtm in dashboard? Surprising. |
@jiridanek I think anyone in the org can |
@ppadti this is maybe too nitpicky, but just so it's less confusing when we look in the log - can you edit the PR title/description and maybe also the commit message here to say "Update dockerfile to use numeric user id"? The problem is that the id is non-numeric and we're switching to numeric. The title sounds like we're doing the opposite. |
/summary Update dockerfile to use numeric user id Can't update commit message, but pr title can be changed through bot |
/retitle Update dockerfile to use numeric user id |
I edited the PR description as well directly. I suppose it's probably fine to have the commit message stay as is, if anyone is confused they'll find the PR. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-8824
Description
This PR aims to update the dockerfile to use numeric user id.
How Has This Been Tested?
make build
to build the image using podmanmake push
to push the image to theIMAGE_REPOSITORY
specified in.env.local
fileUID
as 1001Test Impact
NA
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main