Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile to use numeric user id #3088

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Aug 14, 2024

Closes: RHOAIENG-8824

Description

This PR aims to update the dockerfile to use numeric user id.

How Has This Been Tested?

  • make build to build the image using podman
  • make push to push the image to the IMAGE_REPOSITORY specified in .env.local file
  • deploy the image and check the dashboard container image to have UID as 1001

Test Impact

NA

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti ppadti changed the title Update dockerfile to use non numeric user id [WIP] Update dockerfile to use non numeric user id Aug 14, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Aug 14, 2024
@ppadti ppadti changed the title [WIP] Update dockerfile to use non numeric user id Update dockerfile to use non numeric user id Aug 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 20, 2024
@jiridanek
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

Wow, I can lgtm in dashboard? Surprising.

@mturley
Copy link
Contributor

mturley commented Aug 20, 2024

@jiridanek I think anyone in the org can lgtm here, both lgtm and the approved label are needed to merge.

@mturley
Copy link
Contributor

mturley commented Aug 20, 2024

@ppadti this is maybe too nitpicky, but just so it's less confusing when we look in the log - can you edit the PR title/description and maybe also the commit message here to say "Update dockerfile to use numeric user id"? The problem is that the id is non-numeric and we're switching to numeric. The title sounds like we're doing the opposite.

@jiridanek
Copy link
Member

/summary Update dockerfile to use numeric user id

Can't update commit message, but pr title can be changed through bot

@jiridanek
Copy link
Member

/retitle Update dockerfile to use numeric user id

@openshift-ci openshift-ci bot changed the title Update dockerfile to use non numeric user id Update dockerfile to use numeric user id Aug 20, 2024
@mturley
Copy link
Contributor

mturley commented Aug 20, 2024

I edited the PR description as well directly. I suppose it's probably fine to have the commit message stay as is, if anyone is confused they'll find the PR.

Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a6621c9 into opendatahub-io:main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants