-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-2404] Replace simple deprecated PF selects with SimpleSelect #3072
[RHOAIENG-2404] Replace simple deprecated PF selects with SimpleSelect #3072
Conversation
fc9aef9
to
d8ef9b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good @jeff-phillips-18 ! Tested all the Select menus listed in the PR description.
I noticed the checkmarks aren't getting set in the Select menus under permission settings:
Left another comment below, aside from that LGTM, other menus working as expected.
<SimpleSelect | ||
popperProps={{ appendTo: getDashboardMainContainer() }} | ||
options={sizeOptions()} | ||
style={{ width: '70%' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d8ef9b3
to
90f86dc
Compare
Fixed. |
90f86dc
to
ab4af87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ab4af87
to
e423b26
Compare
Tested all referenced areas to be working. |
e423b26
to
b6b692d
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Towards RHOAIENG-2404
Description
Updates SimpleDropdownSelect to SimpleSelect using the PF Select component rather than Dropdown. This provides the checkmark indicators for the current selection in the menu items.
Replace simple usages of PF Select component with SimpleSelect.
How Has This Been Tested?
Manually tested
Updated Cypress tests
Test Impact
The following components are effected:
Time range
andRefresh interval
select drop downs.Add user -> username selector
Add group -> group name selector
Image Selection
Version selection
Container size
Environment variables -> Add variable:
Select environment variable type
Select environment variable type -> secret -> either -> select one
Request review criteria:
Self checklist (all need to be checked):