[RHOAIENG-10311] Backend service endpoints for connection types

[jeff-phillips-18]

RHOAIENG-10311

Description

Adds backend endpoints for ConnectionType objects.
Includes GET, POST, PUSH, PATH, DELETE.
Adds a frontend service to access these endpoints.

How Has This Been Tested?

This has been tested locally by adding temporary calls in the UI

Test Impact

Tests will need to be added when the UI accesses these new functions.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

[christianvogt]

Can we do the conversion between types? Do you think it makes sense that in app we always work with the parsed object. I don't know of a time when we would need to use the raw config map.

Suggested change

	export const fetchConnectionType = (name: string): Promise<ConfigMapKind> => {
	const url = `/api/connection-types/${name}`;
	return axios
	.get(url)
	.then((response) => response.data)
	.catch((e) => {
	throw new Error(e.response.data.message);
	});
	};
	export const createConnectionType = (connectionType: ConfigMapKind): Promise<ResponseStatus> => {
	const url = `/api/connection-types`;
	return axios
	.post(url, connectionType)
	.then((response) => response.data)
	.catch((e) => {
	throw new Error(e.response.data.message);
	});
	};
	export const fetchConnectionType = (name: string): Promise<ConnectionTypeConfigMapObj> => {
	const url = `/api/connection-types/${name}`;
	return axios
	.get(url)
	.then((response) => toConnectionTypeConfigMapObj(response.data))
	.catch((e) => {
	throw new Error(e.response.data.message);
	});
	};
	export const createConnectionType = (connectionType: ConnectionTypeConfigMap): Promise<ResponseStatus> => {
	const url = `/api/connection-types`;
	return axios
	.post(url, toConnectionTypeConfigMap(connectionType))
	.then((response) => response.data)
	.catch((e) => {
	throw new Error(e.response.data.message);
	});
	};

[christianvogt]

Use errorHandler as we will eventually have stricter ts / eslint rules.

Suggested change

	const error = `Unable to delete connection type: ${e.message}.`;
	const error = `Unable to delete connection type: ${errorHandler(e)}.`;

[christianvogt]

Can't labels be undefined? Also we need both labels to be present.

Suggested change

	return labels[ODH_DASHBOARD_KEY] === 'true' || labels[CONNECTION_TYPE_KEY] === 'true';
	return labels?.[ODH_DASHBOARD_KEY] === 'true' && labels?.[CONNECTION_TYPE_KEY] === 'true';

[christianvogt]

Let's omit this generic patch function and add a specific one that constructs a patch just for setting the enabled annotation:

             {
                op: 'replace',
                path: '/metadata/annotations/opendatahub.io~1enabled',
                value: ...,
              }

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment