-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-7485] Admin - Database status in Model Registry Table #3046
Conversation
We should use the Alert popover to display messages. Use variant Danger for |
@yih-wang Updated. I've also updated the screenshots in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit, everything else LGTM
frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx
Show resolved
Hide resolved
frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the help!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-7485
Description
Show various statuses depending on model registry conditions within a new column labeled "Status" for the model registry list table page.
Degrading popover
Unavailable with multiple messages
(cc @yih-wang)
How Has This Been Tested?
Manually tested with sample data, created unit tests with possible status scenarios
Test Impact
Added unit tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main