[WIP] Spike Effort: Update version of Patternfly to v6 #3038
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
christianvogt
removed request for
mturley,
andrewballantyne,
lucferbux and
christianvogt
jeff-phillips-18
force-pushed
the
patternfly-v6
branch
from
bf985d7
to
dd0cb20
Compare
openshift-merge-robot
added
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -110,7 +109,7 @@ const DashboardDescriptionListGroup: React.FC<DashboardDescriptionListGroupProps | |||
| </Flex> | |||
| </DescriptionListTerm> | |||
| )} | |||
| <DescriptionListDescription className={isEmpty && !isEditing ? text.disabledColor_100 : ''}> | |||
| <DescriptionListDescription className={isEmpty && !isEditing ? text.textColorDisabled : ''}> | |||
There was a problem hiding this comment.
Note: you will need to conditionally render aria-disabled to get passed the accessbility testing. See kubeflow/model-registry#434
jeff-phillips-18
force-pushed
the
patternfly-v6
branch
4 times, most recently
from
63f8185
to
43ba58e
Compare
jeff-phillips-18
force-pushed
the
patternfly-v6
branch
from
54f50fd
to
c1ea58f
Compare
jeff-phillips-18
force-pushed
the
patternfly-v6
branch
from
a13d566
to
e7f0386
Compare
|
/retest |
|
/test images |
| @@ -3,7 +3,7 @@ | |||
| // Override to use the full width of the dialog rather than wrapping early | |||
| .odh-about-dialog { | |||
There was a problem hiding this comment.
patternfly/patternfly/issues/6871 has been resolved in v6. Once the fix has been verified on this branch, AboutDialog.scss and any related references can be removed to close RHOAIENG-9742.
- Fixes to allow codemods to run - Updated by codemods - Lint fixes - Manual build fixes - After class name updater - Global replace “--pf-v6-global--spacer” with “--pf-t--global--spacer” - Fix home page layout - Initial PF updates - Updates following PF core and design feedback - Remove app launcher block from scss - Fixes some scroll issues
jeff-phillips-18
force-pushed
the
patternfly-v6
branch
from
877dfcc
to
0605e45
Compare
|
@jeff-phillips-18: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Working on Spike: RHOAIENG-9577
Steps:
Update package.json to latest v6 versions and update the overrides (manually)
<commit 1>
Run the package install
npm i
Run code mods
npx @patternfly/pf-codemods@latest frontend/src/ --v6
Fix Code mods fail causes (manually)
<commit 2>
Re-Run code mods
npx @patternfly/pf-codemods@latest frontend/src/ --v6
npx @patternfly/pf-codemods@latest frontend/src/ --v6 —fix
<commit 3>
Fix Remaining Code Mod Errors (manually)
<commit 4>
Fix Lint Errors
npm run test:fix
<commit 5>
Manually fix remaining Lint Errors (manually)
<commit 6>
Run class-name-updater
npx @patternfly/class-name-updater --v6 frontend/src/ --fix
<commit 7>
Build attempt
npm run build
Fix remaining build issues (manually)
<commit 8>
Replace “—pf-v6-global—spacer” with “—pf-t—global—spacer”
<commit 9>
Home page fix (manually)
<commit 10>