Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references of docs.openshift.com to the latest OCP version #2932

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

manosnoam
Copy link
Contributor

@manosnoam manosnoam commented Jun 20, 2024

Description

The following files included docs.openshift.com reference to old Openshift versions:

  • docs/dev-setup.md
  • manifests/overlays/apps/apps-onprem/starburst-enterprise/starburstenterprise-app.yaml

Updated to the latest OCP versions.

How Has This Been Tested?

The new URLs was verified to lead to docs.openshift.com of latest OCP version.

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@manosnoam manosnoam added the kind/documentation Improvements or additions to documentation label Jun 20, 2024
@manosnoam manosnoam assigned dgutride and manosnoam and unassigned dgutride Jun 20, 2024
@manosnoam manosnoam requested a review from dgutride June 20, 2024 12:23
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.53%. Comparing base (520c92a) to head (1513643).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
+ Coverage   78.52%   78.53%   +0.01%     
==========================================
  Files        1139     1139              
  Lines       24171    24171              
  Branches     6099     6099              
==========================================
+ Hits        18980    18983       +3     
+ Misses       5191     5188       -3     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520c92a...1513643. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a1c9c39 into opendatahub-io:main Jun 20, 2024
8 checks passed
@manosnoam manosnoam deleted the ocp_version branch June 25, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants