Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloads the page after deleting DSPv1 pipeline server #2863

Merged
merged 1 commit into from
May 30, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented May 30, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-5325

Description

The UI page reloads/refreshed when DSPv1 pipeline server is deleted

Screencast.from.2024-05-30.15-45-06.webm

How Has This Been Tested?

  1. Needed DSPV1 pipeline version
    (to do this In the openshift console ->navigate to DataSciencePipelinesApplication within your project/namespace, search for dspVersion: v2 change v2 to v1 and save

  2. Check for the warning in the dashboard UI

  3. click on Delete pipeline server button and delete the version

  4. once deleted, check whether the UI is refreshed

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.50%. Comparing base (197b42d) to head (bdfef03).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2863   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files        1110     1110           
  Lines       23482    23482           
  Branches     5917     5917           
=======================================
+ Hits        18199    18200    +1     
+ Misses       5283     5282    -1     
Files Coverage Δ
...cepts/pipelines/EnsureCompatiblePipelineServer.tsx 80.95% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073cb0e...bdfef03. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 20d69a2 into opendatahub-io:main May 30, 2024
8 checks passed
@pnaik1 pnaik1 deleted the RHOAIENG-5325 branch July 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants