Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pipelineList tests #2854

Merged
merged 1 commit into from
May 29, 2024

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented May 28, 2024

RHOAIENG-3833

Description

Updated the pipelineList tests such that its functionality would be tested more rigorously.

How Has This Been Tested?

I ran npm run test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 28, 2024
Copy link
Contributor

openshift-ci bot commented May 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.48%. Comparing base (cd93b29) to head (8ac7895).
Report is 43 commits behind head on main.

Current head 8ac7895 differs from pull request most recent head ff076c7

Please upload reports for the commit ff076c7 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
+ Coverage   77.40%   77.48%   +0.07%     
==========================================
  Files        1101     1109       +8     
  Lines       23168    23395     +227     
  Branches     5841     5890      +49     
==========================================
+ Hits        17933    18127     +194     
- Misses       5235     5268      +33     

see 61 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd93b29...ff076c7. Read the comment docs.

@rsun19 rsun19 marked this pull request as ready for review May 28, 2024 21:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label May 28, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit becdc5c into opendatahub-io:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants