Internal Image Registry Dependency Removal support

[lucferbux]

Closes https://issues.redhat.com/browse/RHOAIENG-5414

Description

Fix an issue with the new implementation of https://issues.redhat.com/browse/RHOAIENG-5264 to make sure we render the correct Image Stream selection

Before:

After:

How Has This Been Tested?

1. Get the latest version of the notebook controller (see instructions here)
2. Deploy a model
3. Check the image selected is correct

Test Impact

Currently no coverage in the fix, will follow up with test coverage of the function.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.41%. Comparing base (bac0976) to head (79b5e11).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   77.40%   77.41%           
=======================================
  Files        1101     1101           
  Lines       23192    23197    +5     
  Branches     5848     5852    +4     
=======================================
+ Hits        17951    17957    +6     
+ Misses       5241     5240    -1     

Files	Coverage Δ
...s/screens/detail/notebooks/useNotebookImageData.ts	89.18% <87.50%> (+1.68%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac0976...79b5e11. Read the comment docs.

[lucferbux]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lucferbux]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atheo89]

Tested this change on a cluster without an internal registry, and it works as expected. However, in a cluster with internal registry, there is a strange behavior: it always picks up the code-server notebook details and metadata, and in reality i have deployed a minimal notebook.

NOTE: It behaves the same with and without the new odh-nbc controller latest changes

[jstourac]

Adding another observation on a cluster where the internal registry is removed:

1. Create a workbench with jupyter-minimal-notebook imagestream
2. Notebook image value is shown properly on Dashboard as Minimal Python
3. Then import a custom image (same as is used in this jupyter-minimal-notebook imagestream) and name it as custom-minimal
4. The Notebook image value shown now changed to custom-minimal

[andrewballantyne]

@jstourac @atheo89 please log bugs so we can chase these down -- sounds like something funky in the lookup logic and we need to treat it as a bug.

[atheo89]

@jstourac @atheo89 please log bugs so we can chase these down -- sounds like something funky in the lookup logic and we need to treat it as a bug.

Hi Andrew, I don't see any related logs that could potentially reveal the bug on dashboard pods

[lucferbux]

@jstourac @atheo89 can you guys create an issue for this? I've tried to replicate the issue, in a regular cluster the notebook image is working just fine, I would appreciate getting a cluster without internal registry.

[jstourac]

I created this issue for tracking these two https://issues.redhat.com/browse/RHOAIENG-7917.