-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-4999] Details page for archived runs #2833
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
==========================================
- Coverage 77.48% 77.43% -0.05%
==========================================
Files 1110 1110
Lines 23482 23515 +33
Branches 5917 5932 +15
==========================================
+ Hits 18196 18210 +14
- Misses 5286 5305 +19
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
5d3702b
to
65f06dc
Compare
"Clone" vs "Duplicate" was discussed here a few months ago. Unless something has changed, I believe the intention was to keep the "Duplicate" wording. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing clarity on this @jpuzz0 - based on that discussion it looks like the mocks are out of date, will revert back to Duplicate
. cc @yannnz @xianli123
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the conversation in the demo of this work during the Pipelines Review meeting this morning, based on feedback from @yannnz we want to disable the Restore button on Archived runs, and add a tooltip as shown below.
It was also noted by Fede that, when navigating to an archived experiment from "Experiments and Runs", we want to set the Archived tab as the active tab:
frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableRow.tsx
Outdated
Show resolved
Hide resolved
...nd/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsActions.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/pipelinesDetails/PipelineDetailsTitle.tsx
Outdated
Show resolved
Hide resolved
...nd/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsActions.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableRow.tsx
Outdated
Show resolved
Hide resolved
66d3c85
to
a4d4e74
Compare
...nd/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsActions.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableRow.tsx
Outdated
Show resolved
Hide resolved
Need to verify this
|
ead6fef
to
72f359d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
...nd/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsActions.tsx
Show resolved
Hide resolved
...nd/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsActions.tsx
Outdated
Show resolved
Hide resolved
723c2b9
to
9ac0619
Compare
add archived labels and additional dropdown items format, update tests update test update instances of Duplicate to Clone fix lint PR feedback: reverts Clone, disables restore on archived run, fixes route from archived experiment PR feedback: fix route, remove helper functions fix tests update ExperimentTableRow logic to render dropdown items correctly, use StorageStateKF instead of location' add dropdown option to archive fix error fix linting error apply Gage diff
/lgtm |
Closes https://issues.redhat.com/browse/RHOAIENG-4999
Description
How Has This Been Tested?
Test Impact
Updated PipelinesTopology.cy.ts.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main