-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added useGroup websocket #2830
added useGroup websocket #2830
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
==========================================
+ Coverage 77.42% 77.52% +0.09%
==========================================
Files 1102 1109 +7
Lines 23203 23395 +192
Branches 5854 5890 +36
==========================================
+ Hits 17965 18136 +171
- Misses 5238 5259 +21
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me. Can you update the PR description to test useGroups
on the UI side? also change the test impact.
1f70192
to
558ad70
Compare
Updated the PR accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
558ad70
to
7d58b63
Compare
Tested opening the group dropdown and adding a new group using OpenShift Console in another window and observing the list being updated immediately. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: https://issues.redhat.com/browse/RHOAIENG-5366
Description
Replaces groups.ts#listGroups with useGroups hook which is a wrapper on top of the dynamic-plugin-sdk useK8sWatchResource hook.
How Has This Been Tested?
Be a clusteradmin
As a adminuser , the dropdown is not visible
Test Impact
Unit test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main