Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-2989] artifact node drawer details section #2811

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented May 13, 2024

Starts: RHOAIENG-2989

Description

Fetches the artifact context for the run, now displaying those MLMD artifact details. Virtualization will be a follow-up PR.

image image (cc yannnz)

Test Impact

Will include tests in follow-up PR if applicable.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 13, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2989-artifact-run-node-artifact-details branch from 2ed9d91 to 045a2dc Compare May 13, 2024 11:04
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 13, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2989-artifact-run-node-artifact-details branch 2 times, most recently from f30298c to d02c797 Compare May 14, 2024 15:09
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 78.18%. Comparing base (8645fe6) to head (b6d2e2d).

❗ Current head b6d2e2d differs from pull request most recent head c76698a. Consider uploading reports for the commit c76698a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2811      +/-   ##
==========================================
+ Coverage   77.32%   78.18%   +0.85%     
==========================================
  Files        1093     1080      -13     
  Lines       23026    22689     -337     
  Branches     5799     5739      -60     
==========================================
- Hits        17805    17739      -66     
+ Misses       5221     4950     -271     
Files Coverage Δ
...pelines/apiHooks/mlmd/useGetEventsByExecutionId.ts 71.42% <75.00%> (+71.42%) ⬆️
...ails/pipelineRun/PipelineRunDrawerRightContent.tsx 91.66% <75.00%> (-8.34%) ⬇️
.../pipelineRun/artifacts/usePipelineRunArtifacts.tsx 87.50% <87.50%> (ø)
...ipelinesDetails/pipelineRun/PipelineRunDetails.tsx 83.60% <90.47%> (+1.78%) ⬆️
...lobal/experiments/artifacts/useGetArtifactsList.ts 6.25% <0.00%> (ø)
...lines/apiHooks/mlmd/useArtifactsFromMlmdContext.ts 58.33% <58.33%> (ø)
...pts/pipelines/topology/usePipelineTaskTopology.tsx 91.46% <61.53%> (-5.91%) ⬇️
...ails/pipelineRun/artifacts/ArtifactNodeDetails.tsx 14.28% <14.28%> (ø)
...ipelineRun/artifacts/ArtifactNodeDrawerContent.tsx 23.52% <23.52%> (ø)

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8645fe6...c76698a. Read the comment docs.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2989-artifact-run-node-artifact-details branch 2 times, most recently from 9f2e168 to b6d2e2d Compare May 14, 2024 18:50
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just left a small question that doesn't block the approval.
/lgtm

@Gkrumbach07
Copy link
Member

/approve

lets make sure not to close out the issue as we still need to add metrics viz

Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 15, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2989-artifact-run-node-artifact-details branch from b6d2e2d to c76698a Compare May 15, 2024 19:41
@openshift-ci openshift-ci bot removed the lgtm label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 15, 2024
@jpuzz0 jpuzz0 added the lgtm label May 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5fcd504 into opendatahub-io:main May 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants