-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-2989] artifact node drawer details section #2811
[RHOAIENG-2989] artifact node drawer details section #2811
Conversation
2ed9d91
to
045a2dc
Compare
f30298c
to
d02c797
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 77.32% 78.18% +0.85%
==========================================
Files 1093 1080 -13
Lines 23026 22689 -337
Branches 5799 5739 -60
==========================================
- Hits 17805 17739 -66
+ Misses 5221 4950 -271
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
9f2e168
to
b6d2e2d
Compare
frontend/src/pages/pipelines/global/experiments/artifacts/useGetArtifactsList.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just left a small question that doesn't block the approval.
/lgtm
/approve lets make sure not to close out the issue as we still need to add metrics viz |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b6d2e2d
to
c76698a
Compare
New changes are detected. LGTM label has been removed. |
Starts: RHOAIENG-2989
Description
Fetches the artifact context for the run, now displaying those MLMD artifact details. Virtualization will be a follow-up PR.
(cc yannnz)Test Impact
Will include tests in follow-up PR if applicable.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main