Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mr): routes etc and empty state for registered deployments #2793

Conversation

gitdallas
Copy link
Contributor

initial progress towards https://issues.redhat.com/browse/RHOAIENG-6636

Description

includes setting up the tab, routes, and the component with the empty state
image

How Has This Been Tested?

na, just setting up a skeleton with empty state for now

Test Impact

none

Request review criteria:

can access tab with route and see empty state

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from dpanshug and ppadti May 9, 2024 15:29
@gitdallas gitdallas force-pushed the feat/mr-registereddeployments-tab-and-empty branch from cee9af0 to 0eeb317 Compare May 9, 2024 15:45
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit regarding data fetching, rest looks ok!

@gitdallas gitdallas force-pushed the feat/mr-registereddeployments-tab-and-empty branch 2 times, most recently from 7a91908 to 88232f0 Compare May 9, 2024 17:15
@gitdallas gitdallas requested a review from lucferbux May 9, 2024 17:16
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good first PR to add scaffolding

@openshift-ci openshift-ci bot added the lgtm label May 13, 2024
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux
Copy link
Contributor

oh @gitdallas we got some conflicts after the latest merges.

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 13, 2024
@gitdallas gitdallas force-pushed the feat/mr-registereddeployments-tab-and-empty branch from 88232f0 to e80751a Compare May 13, 2024 17:27
@openshift-ci openshift-ci bot removed the lgtm label May 13, 2024
Copy link
Contributor

openshift-ci bot commented May 13, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 13, 2024
@gitdallas gitdallas added the lgtm label May 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 77.63%. Comparing base (93c0851) to head (e80751a).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
+ Coverage   77.61%   77.63%   +0.02%     
==========================================
  Files        1075     1076       +1     
  Lines       22604    22611       +7     
  Branches     5713     5715       +2     
==========================================
+ Hits        17545    17555      +10     
+ Misses       5059     5056       -3     
Files Coverage Δ
...nd/src/pages/modelRegistry/ModelRegistryRoutes.tsx 66.66% <ø> (ø)
.../modelRegistry/screens/EmptyModelRegistryState.tsx 92.85% <100.00%> (+1.19%) ⬆️
...nDetails/ModelVersionRegisteredDeploymentsView.tsx 33.33% <33.33%> (ø)
...ns/ModelVersionDetails/ModelVersionDetailsTabs.tsx 12.50% <0.00%> (-4.17%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c0851...e80751a. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 37469fd into opendatahub-io:main May 13, 2024
6 checks passed
@gitdallas gitdallas deleted the feat/mr-registereddeployments-tab-and-empty branch May 13, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants