-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mr): routes etc and empty state for registered deployments #2793
feat(mr): routes etc and empty state for registered deployments #2793
Conversation
cee9af0
to
0eeb317
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit regarding data fetching, rest looks ok!
...rc/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionRegisteredDeploymentsView.tsx
Outdated
Show resolved
Hide resolved
7a91908
to
88232f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Good first PR to add scaffolding
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oh @gitdallas we got some conflicts after the latest merges. |
Signed-off-by: gitdallas <[email protected]>
88232f0
to
e80751a
Compare
New changes are detected. LGTM label has been removed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
+ Coverage 77.61% 77.63% +0.02%
==========================================
Files 1075 1076 +1
Lines 22604 22611 +7
Branches 5713 5715 +2
==========================================
+ Hits 17545 17555 +10
+ Misses 5059 5056 -3
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
initial progress towards https://issues.redhat.com/browse/RHOAIENG-6636
Description
includes setting up the tab, routes, and the component with the empty state
How Has This Been Tested?
na, just setting up a skeleton with empty state for now
Test Impact
none
Request review criteria:
can access tab with route and see empty state
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main