Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrustyAI APIs to use new endpoint (RHOAINENG-6620) #2791

Merged
merged 2 commits into from
May 10, 2024

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented May 9, 2024

Closes: RHOAIENG-6620

Description

Updates trusty ai API client to filter only for bias metrics when querying for the list of all Bias Metric Configs.

How Has This Been Tested?

Prerequisites:

  • Deploy on a cluster with the following TrustyAI section in your DSC:
trustyai:
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: ''
            uri: 'https://github.com/ruivieira/trustyai-service-operator/tarball/RHOAIENG-6622-dev'
  • Create a new project, enable trustyai and deploy demo models.
  • Train demo models and hit them with real world data
  • Create a few Bias Metric Configs
  • Create an Identity metric via the CLI

Testing:

  • Visit the bias metrics page, make sure the charts all work
  • Goto the configure screen
  • Verify in the network tab of your browser that the call to endpoint: api/service/trustyai/model-namespace/trustyai-service/metrics/all/requests now contains the query parameter ?type=fairness.

Test Impact

None.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and ppadti May 9, 2024 10:25
@alexcreasy alexcreasy added the do-not-merge/hold This PR is hold for some reason label May 9, 2024
@openshift-ci openshift-ci bot removed the lgtm label May 9, 2024
@alexcreasy alexcreasy added do-not-merge/hold This PR is hold for some reason and removed do-not-merge/hold This PR is hold for some reason labels May 9, 2024
@openshift-ci openshift-ci bot added the lgtm label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexcreasy alexcreasy removed the do-not-merge/hold This PR is hold for some reason label May 9, 2024
@alexcreasy
Copy link
Contributor Author

/restest

Copy link
Contributor

openshift-ci bot commented May 10, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-bot openshift-merge-bot bot merged commit 814b201 into opendatahub-io:main May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants