Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for version details and Refactoring model registry folder structure #2786

Merged

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented May 8, 2024

Closes: RHOAIENG-2238

Description

Added cypress tests for model version details test
Refactoring model registry folder structure

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 8, 2024
@dpanshug
Copy link
Contributor Author

dpanshug commented May 8, 2024

To be merged after #2782 & #2770

@dpanshug dpanshug requested a review from lucferbux May 8, 2024 13:59
@dpanshug dpanshug force-pushed the model-version-details-tests branch 4 times, most recently from b817bcc to deca303 Compare May 9, 2024 17:11
@dpanshug dpanshug force-pushed the model-version-details-tests branch 3 times, most recently from ecc9576 to 493e169 Compare May 13, 2024 13:38
Refactoring model registry folder structure
@dpanshug dpanshug force-pushed the model-version-details-tests branch from 493e169 to aca28ab Compare May 13, 2024 14:17
@dpanshug
Copy link
Contributor Author

/retest-required

@dpanshug dpanshug changed the title [WIP] Tests for version details and Refactoring model registry folder structure Tests for version details and Refactoring model registry folder structure May 13, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label May 13, 2024
@lucferbux
Copy link
Contributor

/retest

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 54f4402 into opendatahub-io:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants