Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-2987] Artifacts - Details Page #2765

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Apr 30, 2024

Closes: RHOAIENG-2987

Description

Details page for artifacts accessed by clicking the table, then clicking on the name of the artifact. The page only renders the Overview tab and its data. The JIRA asked for an empty state for Lineage explorer, but since there is no design screen showing what that might look like, I've just disabled the tab for now.

How Has This Been Tested?

Added unit tests that verifies data being rendered on the page since Cypress does not support intercepting application/grpc-web+proto content type requests.

I've also added a simple unit test for the artifacts list table which mocks and renders some data.

How to test

Navigate to the artifacts table from the left nav, click on an artifact name, verify you're routed to the details page, verify the visual matches the design and the data is correct.

image (cc @yannnz)

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2987-artifacts-detail-page branch 2 times, most recently from 0d90b66 to 1e4968f Compare May 1, 2024 03:00
@DaoDaoNoCode DaoDaoNoCode mentioned this pull request May 2, 2024
7 tasks
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! just the two comments

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2987-artifacts-detail-page branch 3 times, most recently from bc85867 to 93687a8 Compare May 3, 2024 18:34
@DaoDaoNoCode
Copy link
Member

All lgtm, one last thing, could you please add the link to the artifact details page here? https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/pages/pipelines/global/experiments/executions/details/ExecutionDetailsInputOutputSection.tsx#L75-L76. I left it in my previously merged PR because the artifact details page was not created at that time. Thanks a lot!

@Gkrumbach07
Copy link
Member

Screenshot 2024-05-03 at 2 00 04 PM
can you make the json printed on multiple lines like it is in KF and executions

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2987-artifacts-detail-page branch from 93687a8 to 6782833 Compare May 3, 2024 20:58
@Gkrumbach07
Copy link
Member

tested again and the json looks good now

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 3, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2987-artifacts-detail-page branch from 6782833 to 9eeeae6 Compare May 3, 2024 21:27
@openshift-ci openshift-ci bot removed the lgtm label May 3, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2987-artifacts-detail-page branch 2 times, most recently from 993a2fd to 36bb0fe Compare May 3, 2024 21:42
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2987-artifacts-detail-page branch from 36bb0fe to 76bea1b Compare May 3, 2024 21:45
@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ba52843 into opendatahub-io:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants