-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dw): 5292 - improve chart look and feel #2762
chore(dw): 5292 - improve chart look and feel #2762
Conversation
PTAL @xianli123 @cfullam1 @yannnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth returning to see if we can avoid magic numbers for width/height, but they may be unavoidable. Nice work, LGTM
8837593
to
4e9ab9c
Compare
Signed-off-by: gitdallas <[email protected]> feat(dw): requested resource charts adjust width Signed-off-by: gitdallas <[email protected]> feat(dw): improve top usage charts Signed-off-by: gitdallas <[email protected]> feat(dw): improve status overview chart Signed-off-by: gitdallas <[email protected]> lints Signed-off-by: gitdallas <[email protected]> feat(dw): usage chart tooltip better placement Signed-off-by: gitdallas <[email protected]>
4e9ab9c
to
9884eb9
Compare
tested this on mocked data and the graphs look good. not testing on live data as this only is changing how things are rendered /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
closes: https://issues.redhat.com/browse/RHOAIENG-5292
Description
improve look and feel of charts. includes:
Screens (you'll have to expand images to really see the difference in how the charts sizing compares to the size of the text outside of the charts)
Status Overview before:
Status Overview after:
Project metrics before:
Project metrics after:
Usage tooltips:
How Has This Been Tested?
tested locally, existing tests still pass
Test Impact
none
Request review criteria:
make sure charts look good and handle resize well
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main