Model Registry: Initial content of model details tab with stub editable fields and tab navigation handling #2760
Conversation
mturley
force-pushed
the
RHOAIENG-2235-model-details-section
branch
2 times, most recently
from
29a10b7
to
45bd9c5
Compare
…b navigation handling Signed-off-by: Mike Turley <[email protected]>
mturley
force-pushed
the
RHOAIENG-2235-model-details-section
branch
from
45bd9c5
to
ea23ed0
Compare
| const [unsavedLabels, setUnsavedLabels] = React.useState(labels); | ||
| const [isSavingEdits, setIsSavingEdits] = React.useState(false); | ||
|
|
||
| const editUnsavedLabel = (newText: string, index: number) => { |
There was a problem hiding this comment.
I feel that if this is gonna be reused in the details view we can move it into a utils right?
Not needed right now, can be refactor on @dpanshug pr
There was a problem hiding this comment.
Resolving conversation it can be done in another PR
There was a problem hiding this comment.
This whole EditableLabelsDescriptionListGroup is already ready to be reused anywhere in the UI, will just drop it in for version details
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ok, so far it's going great! This might unblock the rest of the work! |
Part of RHOAIENG-2235
Description
Implements most of the "Details" tab of the registered model page. Note that the "Properties" section is not functional and will be implemented in a followup PR. Also note that while the Description and Labels sections have editable functionality implemented, the actual last step of persisting the edits to the API is a stub promise that simply waits 2 seconds in order to show the "saving" state (edits are not allowed while saving). Implementing the real API patch requests will be in a separate PR.
Model details tab:
Description field in edit mode:
Description field disabled while saving (currently a stub 2-second-delay promise):
Labels in edit mode:
Editing an existing label:
Add label modal:
Label editing disabled while saving (currently a stub 2-second-delay promise):
How Has This Been Tested?
Model RegistrytabRegistered Modelstable and then click theDetailstab, or click the kebab menu at the right of a registered model and clickView details/detailsand/versionssubpathsTest Impact
Will be added shortly.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main