Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-5496] Landing page: New home page hint #2752

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Apr 26, 2024

Closes: RHOAIENG-5496

Description

Adds a hint to the landing page directing users how to find the previous landing page

How Has This Been Tested?

Tested locally

Test Impact

Added e2e tests

Screenshots

image

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

/cc @jgiardino

Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: jgiardino.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Closes: RHOAIENG-5496

Description

Adds a hint to the landing page directing users how to find the previous landing page

How Has This Been Tested?

Tested locally

Test Impact

Added e2e tests

Screenshots

image

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

/cc @jgiardino

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jgiardino
Copy link

The updates look great! There are a few things that would be good to address if possible:

  • Can you add the same border radius that we have on the project cards to this card?
  • Can there be a max-width of 880px applied to the contents?
  • Can the link use the same font size as the surrounding text?

@jeff-phillips-18
Copy link
Contributor Author

jeff-phillips-18 commented Apr 29, 2024

The updates look great! There are a few things that would be good to address if possible:

  • Can you add the same border radius that we have on the project cards to this card?
  • Can there be a max-width of 880px applied to the contents?
  • Can the link use the same font size as the surrounding text?

I have addressed all three and updated the screenshots above.

@openshift-ci openshift-ci bot added the lgtm label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ab0d1b5 into opendatahub-io:main Apr 30, 2024
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the home-page-hint branch April 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants