Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter tile, merge cert info from old notebook to avoid loss #2750

Conversation

andrewballantyne
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-6455

Description

Merges in the volumeMounts, and the notebook container's volumes & envs to keep the cert information around instead of overriding it with the k8s patch logic.

How Has This Been Tested?

Manually using the Jupyter tile.

Needs self signed cert stuff setup (cc @harshad16 for details)

  1. Go to the Jupyter tile
  2. Create a notebook - details do not matter (if you have one before this, delete it & the PVC)
  3. Check the yaml on OpenShift Console (look for the ca-bundle references)
  4. Stop Notebook
  5. Create the notebook again
  6. Check the yaml still has the ca-bundle references

Test Impact

None, backend only change.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

/cc @harshad16

@openshift-ci openshift-ci bot requested a review from harshad16 April 26, 2024 17:05
@andrewballantyne
Copy link
Member Author

@harshad16 please give it a test and let me know if this is what you're looking for.

@harshad16
Copy link
Member

Tested this in our dev cluster.
the solution sticks to the Notebook CR changes as expected.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks for the quick solution.

Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 75efea8 into opendatahub-io:main Apr 26, 2024
6 checks passed
@andrewballantyne andrewballantyne deleted the merge-better-jupyter-notebook branch June 26, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants