Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional cypress test case for pipeline detail #2746

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Apr 25, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-3834

Description

added additional test for pipeline detail page

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 requested review from uidoyen and ppadti April 25, 2024 09:36
@pnaik1 pnaik1 force-pushed the pipeline-detail branch 3 times, most recently from 6542606 to 8dbd5e8 Compare April 26, 2024 07:21
Copy link
Contributor

@uidoyen uidoyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppadti
Copy link
Contributor

ppadti commented Apr 29, 2024

/lgtm

@alexcreasy
Copy link
Contributor

Ran in browser locally without issues, saw no issues with the test code.

/approve

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5c0037b into opendatahub-io:main Apr 29, 2024
6 checks passed
@ashley-o0o ashley-o0o mentioned this pull request May 3, 2024
7 tasks
@pnaik1 pnaik1 deleted the pipeline-detail branch July 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants