Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-2977] Artifacts table #2744

Merged

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Apr 24, 2024

Closes: RHOAIENG-2977

Description

Artifacts table, filter toolbar, pagination.

image (cc @yannnz)

Demos

Filtering
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/53a04653-b833-49ec-94ec-70d7bcc666a1

Pagination
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/a532700a-2edd-4288-a013-9731fc5eef89

Testing instructions

Navigate to the Artifacts page from the left nav. Using a project with multiple artifacts, verify pagination, and toolbar filtering works as expected.

How Has This Been Tested?

Cypress does not support intercepting application/grpc-web+proto content type requests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Apr 24, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2977-artifacts-table branch 4 times, most recently from 83ea172 to 82c6b37 Compare April 24, 2024 21:39
@jpuzz0 jpuzz0 changed the title WIP [RHOAIENG-2977] Artifacts table [RHOAIENG-2977] Artifacts table Apr 24, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Apr 24, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2977-artifacts-table branch from 82c6b37 to 1c4bda4 Compare April 24, 2024 23:00
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2977-artifacts-table branch from 1c4bda4 to 4d986b7 Compare April 25, 2024 16:14
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2977-artifacts-table branch from 4d986b7 to 403d399 Compare April 25, 2024 19:21
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well.
/lgtm

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2977-artifacts-table branch from 403d399 to de90699 Compare April 29, 2024 13:52
@openshift-ci openshift-ci bot removed the lgtm label Apr 29, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2977-artifacts-table branch 2 times, most recently from 0f353af to c2b6210 Compare April 29, 2024 14:48
@Gkrumbach07
Copy link
Member

/retest "Pull request / Tests (18.x) (pull_request)"

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@Gkrumbach07: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test odh-dashboard-pr-image-mirror

Use /test all to run all jobs.

In response to this:

/retest "Pull request / Tests (18.x) (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gkrumbach07
Copy link
Member

/retest

@Gkrumbach07
Copy link
Member

/test "Pull request / Tests (18.x) (pull_request)"

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@Gkrumbach07: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test odh-dashboard-pr-image-mirror

Use /test all to run all jobs.

In response to this:

/test "Pull request / Tests (18.x) (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2977-artifacts-table branch from c2b6210 to c9eda61 Compare April 29, 2024 18:54
@Gkrumbach07
Copy link
Member

all good to me.

/approve

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9d58a69 into opendatahub-io:main Apr 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants