-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-2977] Artifacts table #2744
[RHOAIENG-2977] Artifacts table #2744
Conversation
frontend/src/pages/pipelines/global/experiments/artifacts/useGetArtifactsList.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/experiments/artifacts/useGetArtifactsList.ts
Outdated
Show resolved
Hide resolved
83ea172
to
82c6b37
Compare
82c6b37
to
1c4bda4
Compare
frontend/src/pages/pipelines/global/experiments/MlmdListContext.tsx
Outdated
Show resolved
Hide resolved
1c4bda4
to
4d986b7
Compare
frontend/src/pages/pipelines/global/experiments/artifacts/ArtifactsTable.tsx
Outdated
Show resolved
Hide resolved
4d986b7
to
403d399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well.
/lgtm
frontend/src/pages/pipelines/global/experiments/artifacts/useGetArtifactsList.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/experiments/artifacts/ArtifactsTable.tsx
Show resolved
Hide resolved
403d399
to
de90699
Compare
0f353af
to
c2b6210
Compare
/retest "Pull request / Tests (18.x) (pull_request)" |
@Gkrumbach07: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test "Pull request / Tests (18.x) (pull_request)" |
@Gkrumbach07: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c2b6210
to
c9eda61
Compare
all good to me. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Closes: RHOAIENG-2977
Description
Artifacts table, filter toolbar, pagination.
(cc @yannnz)Demos
Filtering
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/53a04653-b833-49ec-94ec-70d7bcc666a1
Pagination
https://github.com/opendatahub-io/odh-dashboard/assets/96431149/a532700a-2edd-4288-a013-9731fc5eef89
Testing instructions
Navigate to the Artifacts page from the left nav. Using a project with multiple artifacts, verify pagination, and toolbar filtering works as expected.
How Has This Been Tested?
Cypress does not support intercepting
application/grpc-web+proto
content type requests.Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main