Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added user management cypress test #2728

Merged
merged 1 commit into from
Apr 24, 2024
Merged

added user management cypress test #2728

merged 1 commit into from
Apr 24, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Apr 19, 2024 •
edited
Loading

Closes: https://issues.redhat.com/browse/RHOAIENG-3813
Closes: https://issues.redhat.com/browse/RHOAIENG-5310

Description

added cypress test for user management

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested a review from uidoyen April 19, 2024 11:08
@pnaik1 pnaik1 force-pushed the userManagement branch 2 times, most recently from feed4eb to cfae327 Compare April 19, 2024 12:12
pnaik1
pnaik1 commented Apr 19, 2024
View reviewed changes
frontend/src/__tests__/cypress/cypress/e2e/projects/projectDetails.cy.ts
projectDetails.findElyraInvalidVersionAlert().should('not.exist');
notebookRow.findOutdatedElyraInfo().should('be.visible');
projectDetails.findElyraInvalidVersionAlert().should('be.visible');
projectDetails.findUnsupportedPipelineVersionAlert().should('not.exist');
});
Copy link
Contributor Author

@pnaik1 pnaik1 Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests where failing continuously , fixed the flaky test

@pnaik1 pnaik1 changed the title added user management added user management cypress test Apr 19, 2024
@pnaik1 pnaik1 force-pushed the userManagement branch 2 times, most recently from 7c12a17 to 5849712 Compare April 22, 2024 10:13
manaswinidas
manaswinidas reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 22, 2024
@openshift-ci openshift-ci bot removed the lgtm label Apr 24, 2024
@ppadti
Copy link
Contributor

ppadti commented Apr 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 24, 2024
andrewballantyne
andrewballantyne requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You stumbled upon an invalid state -- which IS possible for the page to load in that state. We should have a test for an invalid admin/allowed group to make sure the page is not submittable when loaded in that state.

However, your mock is starting in an invalid state, and I think you need to make it start in a valid state and then manipulate it into an invalid state (using props to the mock or modifying the mock after it is returned from the function).

frontend/src/__tests__/cypress/cypress/e2e/userManagement/userManagement.cy.ts Outdated Show resolved Hide resolved
frontend/src/__mocks__/mockGroupConfig.ts Outdated Show resolved Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/userManagement/userManagement.cy.ts Outdated Show resolved Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/userManagement/userManagement.cy.ts Outdated Show resolved Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/userManagement/userManagement.cy.ts Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label Apr 24, 2024
andrewballantyne
andrewballantyne approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite what I asked for, but covers the needed tests.

@openshift-ci openshift-ci bot added the lgtm label Apr 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a3a6b2 into opendatahub-io:main Apr 24, 2024
6 checks passed
@pnaik1 pnaik1 deleted the userManagement branch July 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manaswinidas manaswinidas manaswinidas requested changes

@christianvogt christianvogt christianvogt left review comments

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@uidoyen uidoyen Awaiting requested review from uidoyen

Assignees

@andrewballantyne andrewballantyne

@manaswinidas manaswinidas

@ppadti ppadti

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pnaik1 @ppadti @andrewballantyne @christianvogt @manaswinidas