Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress test for Administration tab #2724

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Apr 18, 2024

Closes: RHOAIENG-3919

Description

This PR aims to add cypress test for administration tab.

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti ppadti force-pushed the administration-page branch 2 times, most recently from a09bfc0 to 690c70a Compare April 19, 2024 10:42
@christianvogt
Copy link
Contributor

This PR may be impacted by #2727 which changes the default user to be a project admin.

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppadti
Copy link
Contributor Author

ppadti commented Apr 22, 2024

This PR may be impacted by #2727 which changes the default user to be a project admin.

Once #2727 is merged, I will update it accordingly.

Copy link
Contributor

@uidoyen uidoyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally.

@uidoyen
Copy link
Contributor

uidoyen commented Apr 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d5464e3 into opendatahub-io:main Apr 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants