Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-5487] Initial "empty state" of home page #2719

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes: RHOAIENG-5487

Description

Adds an initial Home page for the dashboard hidden behind a feature flag. The feature flag is set to disable the page and it will not be shown until/unless it is enabled.

Screen shot

image

How Has This Been Tested?

Tested manually by turning on/off the disableHome flag.

Test Impact

Added e2e test to verify the feature flag is working correctly.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on code front... one suggested change... I wonder if it's not better to do /enabled instead of /applications just to match the /explore. Thoughts?

Let me test it out to verify things.

@openshift-ci openshift-ci bot added the lgtm label Apr 17, 2024
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9c3d1bf into opendatahub-io:main Apr 17, 2024
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the home-page-init branch April 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants