Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read pipeline run node details from mlmd context #2695

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Read pipeline run node details from mlmd context #2695

merged 1 commit into from
Apr 16, 2024

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Apr 9, 2024 •
edited
Loading

JIRA: https://issues.redhat.com/browse/RHOAIENG-4544

Description

Read pipeline executions information from the mlmd service instead of parsing it by ourselves so it's more accurate. If the mlmd service is not available, it will fall back to our current logic.

Screenshot 2024-04-09 at 5 39 21 PM

How Has This Been Tested?

  1. Create a pipeline run
  2. Click on the nodes
  3. Compare it with the KubeFlow Pipeline runs UI, make sure the information is the same with the ones in that UI

Test Impact

N/A, not sure how we should test the mlmd service, I can add it if needed after the PR gets reviewed.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 9, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Apr 9, 2024
@Gkrumbach07
Copy link
Member

/hold

will go in next sprint

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Apr 10, 2024
jpuzz0
jpuzz0 reviewed Apr 12, 2024
View reviewed changes
frontend/src/concepts/pipelines/apiHooks/mlmd/useExecutionsFromContext.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/apiHooks/mlmd/usePipelineRunMlmdContext.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/apiHooks/mlmd/usePipelineRunMlmdContext.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/runLogs/LogsTab.tsx Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/topology/usePipelineTaskTopology.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/topology/parseUtils.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/topology/parseUtils.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/topology/parseUtils.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/topology/parseUtils.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/apiHooks/mlmd/usePipelineRunMlmdContext.ts Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Apr 16, 2024
@DaoDaoNoCode
Copy link
Member Author

@jpuzz0 Updated the PR and let me know, if it looks good I can squash the commits.

jpuzz0
jpuzz0 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm label Apr 16, 2024
@DaoDaoNoCode
Copy link
Member Author

/unhold
New sprint.

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Apr 16, 2024
@Gkrumbach07
Copy link
Member

this looks good.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, jpuzz0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 99fe109 into opendatahub-io:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpuzz0 jpuzz0 jpuzz0 approved these changes

@Gkrumbach07 Gkrumbach07 Awaiting requested review from Gkrumbach07

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@jpuzz0 jpuzz0

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaoDaoNoCode @Gkrumbach07 @jpuzz0 @openshift-merge-robot